Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Add more colorful header patterns, fix dark footer pattern #211

Merged
merged 11 commits into from
Nov 5, 2021
Merged

Add more colorful header patterns, fix dark footer pattern #211

merged 11 commits into from
Nov 5, 2021

Conversation

kjellr
Copy link
Collaborator

@kjellr kjellr commented Nov 5, 2021 •
edited
Loading

Closes #172.
Closes #91.

  • Adds color to many of the theme's header patterns.
  • Renames most of the patterns to be sentence case, and to include the new color in the name when applicable.
  • Removes one pattern that was too similar to all the others (Text-only with all-caps title and tagline).
  • Fixes the final issue for Footer Patterns: Followup Fixes #91, where the dark footer pattern had no padding on the left & right.

Screen Shot 2021-11-05 at 2 20 06 PM

Screen Shot 2021-11-05 at 2 19 56 PM

@kjellr kjellr self-assigned this Nov 5, 2021
@kjellr kjellr added [Component] Block Patterns [Type] Bug Something isn't working [Type] Enhancement New feature or request labels Nov 5, 2021
@kjellr kjellr marked this pull request as ready for review November 5, 2021 18:23
@kjellr kjellr changed the title Add more colorful header patterns Add more colorful header patterns, fix dark footer pattern Nov 5, 2021
jffng
jffng approved these changes Nov 5, 2021
View reviewed changes
Copy link
Collaborator

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closes #172.
Closes #91.

✅ ✅

@jffng jffng merged commit e91a0f8 into trunk Nov 5, 2021
@jffng jffng deleted the try/colorful-header-patterns branch November 5, 2021 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jffng jffng jffng approved these changes

Assignees

@kjellr kjellr

Labels
[Component] Block Patterns [Type] Bug Something isn't working [Type] Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider new block patterns Footer Patterns: Followup Fixes
2 participants
@kjellr @jffng